fix: unfreeze DependencyFactory after command
#1528
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikophil
changed the title
nikophil
force-pushed
the
feat/unfroze-dependencies-after-command
branch
from
e4ec2f3 to
458c7bf
Compare
nikophil
changed the title
DependencyFactory after command
nikophil
commented
Oct 4, 2025
nikophil
force-pushed
the
feat/unfroze-dependencies-after-command
branch
2 times, most recently
from
dd3e71d to
83a2951
Compare
nikophil
force-pushed
the
feat/unfroze-dependencies-after-command
branch
from
83a2951 to
f7f8e8c
Compare
|
I fixed phpstan failures, which are due to a new phpstan version |
|
It seems there are CI jobs failing. Please take a look at this guide for more on how to handle those. Specifically this part |
nikophil
force-pushed
the
feat/unfroze-dependencies-after-command
branch
from
63abad1 to
d717a90
Compare
|
cs fixed 👍 |
greg0ire
approved these changes
Oct 11, 2025
|
@goetas @VincentLanglet please review |
VincentLanglet
approved these changes
Oct 11, 2025
derrabus
reviewed
Oct 12, 2025
| } | ||
| } | ||
|
|
||
| abstract protected function doExecute(InputInterface $input, OutputInterface $output): int; |
There was a problem hiding this comment.
Introducing a new abstract function (to a class that is not internal) is a BC break, isn't it?
There was a problem hiding this comment.
yeah you're right, I acted as this class was internal.
that's strange that roave-backward-compatibility-check workflow did not see it
I've made the method concrete, and it now directly throws an exception. I think this is not a BC anymore
nikophil
force-pushed
the
feat/unfroze-dependencies-after-command
branch
from
d717a90 to
5f7cb42
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When a migration command runs, the
DependencyFactoryis frozen, but never "unfrozen", so it cannot be run several times programmatically, like we would need in Foundry.I propose to unfreeze at the end of all commands, but I'd be also OK to only do it in
doctrine:migration:migrate